CFE-3882: Added strtotime policy function - #6237
Conversation
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
Please add some acceptance tests :)
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Yep, as @larsewi said not much to review here, please add acceptance test. Most code review is in libntech.
|
Marking this PR as stale due to inactivity; it will be closed in 7 days. |
f264368 to
189600a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
38e6fef to
c76539d
Compare
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
The new functions in pipes.h probably deserve their own commit.
13e8c8b to
0486ef1
Compare
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14538/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14538/ |
cf_popen_exact_args is variation of cf_popen when the exact arguments are known at compile time. This skips the quote escaping of ArgSplitCommand which is needed when argv can be of arbitrary length, such as with user input Signed-off-by: Victor Moene <victor.moene@northern.tech>
Ticket: CFE-3882 Changeglog: Title Signed-off-by: Victor Moene <victor.moene@northern.tech>
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14548/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14548/ |
5 participants
No description provided.